Yue2 "stop after" (generate just score.abc, or semantic) - #636
Merged
Merged
Conversation
engival
force-pushed
the
yue2-stop-after
branch
from
September 21, 2026 23:48
0520e9a to
581141f
Compare
engival
marked this pull request as ready for review
September 21, 2026 23:56
Owner
|
@engival One issue should be fixed before merging:
This also conflicts with the model-spec description, which says the semantic setting writes the semantic export. The clean fix is for |
stop_after=abc writes the score and stops; stop_after=semantic also runs the semantic stage and skips the NAR and the VAE, and implies export_semantic since the token stream is all that stage produces. Such a result carries no audio, only artifacts. Default audio: a request that does not set it renders as before. The ABC stage moves into a helper so the early return can use it; Yue2RunResult::audio becomes optional so no empty WAV is written.
engival
force-pushed
the
yue2-stop-after
branch
from
September 22, 2026 01:28
581141f to
6a25741
Compare
Contributor
Author
|
Okay, it's done. stop_after now implies the export. The export flag is only required for getting the semantic at the same time as the wav. |
Owner
|
@engival Thanks! PR merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives you the ability to generate just a score.abc, or the score + semantic, while skipping the final audio render.