Make optional RPM dependencies weak (Recommends) - #45
Merged
Merged
Conversation
Only gcc, pkgconfig, gc-devel and pcre2-devel are needed to compile a basic Crystal program. The rest (openssl, zlib, yaml, xml2, gmp, git, make) are only needed by parts of the stdlib or by shards, so they're now Recommends. dnf still installs them by default, but users can opt out with install_weak_deps=False. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
spuun
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
gcc,pkgconfig,gc-develandpcre2-develare needed to compile a basic Crystal program. The rest are only needed by parts of the stdlib or by shards, so this moves them toRecommends::openssl-devel,zlib-devel,libyaml-devel,libxml2-devel,gmp-develgit,makednf installs weak dependencies by default, so nothing changes for most users. Minimal installs can skip them with
--setopt=install_weak_deps=False.libffi-develis intentionally left out. Only the interpreter uses libffi, and rpmbuild's automatic dependency detection already requires the runtimelibffi.so.8.🤖 Generated with Claude Code