[PWGLF] added process function to check effect of spatial calibration on v1 - #18015
Merged
Merged
Conversation
prottayCMT
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
September 22, 2026 18:14
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
romainschotter
previously approved these changes
Sep 22, 2026
romainschotter
enabled auto-merge (squash)
September 22, 2026 18:23
Collaborator
|
Error while checking build/O2Physics/staging for 694707d at 2026-09-22 21:32: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 694707d at 2026-09-22 21:34: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for a1cec3a at 2026-09-23 10:35: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 694707d at 2026-09-23 01:25: Full log here. |
romainschotter
approved these changes
Sep 23, 2026
vkucera
reviewed
Sep 23, 2026
Comment on lines
+1327
to
+1330
| static constexpr double massLambda = o2::constants::physics::MassLambda; | ||
| static constexpr double massK0s = o2::constants::physics::MassK0Short; | ||
| static constexpr double massPr = o2::constants::physics::MassProton; | ||
| static constexpr double massPi = o2::constants::physics::MassPionCharged; |
Collaborator
There was a problem hiding this comment.
Please do not create aliases for existing constants. It's misleading and creates room for errors. Please use the existing constants directly instead. The namespace prefix can be removed if you use a using directive.
vkucera
reviewed
Sep 23, 2026
Comment on lines
+1409
to
+1410
| auto ux = TMath::Cos(GetPhiInRange(track.phi())); | ||
| auto uy = TMath::Sin(GetPhiInRange(track.phi())); |
Collaborator
There was a problem hiding this comment.
There is no reason to use ROOT functions here. O2 works with fundamental C++ types so the best is to stick to the STL algorithms.
Collaborator
|
@prottayCMT Please fix the remaining errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.