Skip to content

[OGUI-746] url parameter direct livemode - #2708

Draft
Houwie7000 wants to merge 24 commits into
devfrom
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode
Draft

Houwie7000 wants to merge 24 commits into
devfrom
improvement/Houwie7000/OGUI-746/url-parameter-direct-livemode

Conversation

@Houwie7000

@Houwie7000 Houwie7000 commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

Ticket:

Accept a live URL parameter. When it is set to true, attempt to start live mode as soon as its dependencies have loaded and allow.

Needed so the AliECS GUI can link from a running environment to InfoLogger GUI in live mode with autoscroll (OGUI-722).

Code:

Previously, the Query/Live mode switching and their button styling were handled in the commandLogs view by toggleButtonStates, which stored the button state in module-level variables. Starting live mode from the URL meant interacting with the view to update these variables, which prom[ted a refactor to extract logic from the view to a model.

  • Btn styling - derived from activeMode via constant in commandLogs
  • Mode click actions - moved into the Log model.
  • Starting live mode from the url - model keeps promises for live mode's dependencies and once available goes live. If not, shows a warning.

Reviewer:

The reviewer can test using this URL (remove runNumber to match more logs, included as this is the specific use case the ticket mentions):

http://localhost:8080/?q=%7B%22timestamp%22%3A%7B%22since%22%3A%22-1h%22%7D%2C%22run%22%3A%7B%22match%22%3A%22248025%22%7D%2C%22severity%22%3A%7B%22in%22%3A%22I%20W%20E%20F%22%7D%7D&live=true

To note:

  • Switching between Query, Live and pausing/resuming live mode. The button styling should match the previous ILG behaviour.
  • When live mode was specifically specified in the URL and it happens that the ILG server is unavailable the page should raise a notification.

@Houwie7000
Houwie7000 requested a review from graduta as a code owner January 6, 2025 09:28
@Houwie7000 Houwie7000 changed the title Improvement/houwie7000/og UI 746/url parameter direct livemode [OGUI-746] url parameter direct livemode Jan 6, 2025
@isaachilly
isaachilly self-requested a review as a code owner September 21, 2026 08:11
Comment thread InfoLogger/public/Model.js Fixed
I found too much operating logic was occurring in the view so I have refactored the query/live button behaviour so that mode switching is handled by the model instead.

This centralises the logic again and simplifies the view.
@isaachilly isaachilly self-assigned this Sep 21, 2026
@isaachilly
isaachilly marked this pull request as draft September 21, 2026 16:32
Await the needed information/processes calls and then start live mode if it was requested. Do not keep polling or manage a timeout etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants