feat: Add configurable cookie Domain for cross-subdomain sessions - #118
Merged
Merged
Conversation
Cookies were always host-only, so a session issued by api.example.com was never sent to app.example.com. Add `session.domain` (and the `AUTHULA_COOKIE_DOMAIN` env var) and apply it to the session, CSRF, TOTP and impersonation cookies on both set and clear. The value is validated against BaseURL at startup since net/http silently drops invalid domains. Also fix CSRF and admin cookie clears that did not mirror the attributes they were set with, and consolidate SameSite parsing in util.ParseSameSite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookies were always host-only, so a session issued by api.example.com was never sent to app.example.com. Add
session.domain(and theAUTHULA_COOKIE_DOMAINenv var) and apply it to the session, CSRF, TOTP and impersonation cookies on both set and clear. The value is validated against BaseURL at startup since net/http silently drops invalid domains.Also fix CSRF and admin cookie clears that did not mirror the attributes they were set with, and consolidate SameSite parsing in util.ParseSameSite.