Conversation
gabisonia
requested review from
DevJonny,
holytshirt and
iancooper
as code owners
September 23, 2026 17:47
iancooper
approved these changes
Sep 24, 2026
Member
|
Thanks @gabisonia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default mapper is
JsonMessageMapper<>, but 13 XML documentation sites describe a CloudEvents JSON envelope. Correct those descriptions and resolve the generic mapper references. Add 12 regression cases asserting plain JSON round trips through the sync and async defaults registered withAddBrighterandAddConsumers.The RMQTaskQueue sample also loses
Greetingduring deserialization because its parameterless constructor leaves a getter-only property unpopulated. Add the public setter proposed in the issue so the greeting survives the round trip.Related Issues
Fixes #4277
Type of Change
Checklist
Additional Notes
Validation:
The permanent regression tests use the existing TestDoubles convention. Sample-specific checks were local only; no live RabbitMQ broker was used.