feat: add icons to ComponentContext adapted to stream-chat-react@15 - #3294
Open
MartinCupela wants to merge 1 commit into
Open
MartinCupela wants to merge 1 commit into
MartinCupela wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Size Change: +4.72 kB (+0.57%) Total Size: 838 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-v15 #3294 +/- ##
==============================================
Coverage ? 85.21%
==============================================
Files ? 527
Lines ? 15487
Branches ? 4868
==============================================
Hits ? 13198
Misses ? 2289
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Sep 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Port #3246 to v15.
Differences from the v14 PR (#3246)
@deprecatednotes on superseded icon propsIconSlotshand-lists 86 nameskeyof typeof icons(87)IconXCircleis missing, so it is not overridable on master. A derived union cannot driftSearchBar.tsxnot convertedIconXCirclenever entered the unionIconComponent=ComponentType<ComponentPropsWithoutRef<'svg'>>ComponentType<BaseIconProps>decorativea11y opt-out through the slots[][icons][]never picks up an icon swapped at runtime. v15'sWithComponentsalready memoizes, so identity stays stableQuotedMessagePreviewdeclares a localIconSetof 8 namesRequired<IconSlots>components/ChatView/ChatView.tsxconvertedSlotLayout/ChatView.tsxinsteadChannelManagementView.test.tsxrepointed from theIconsbarrel toIcons/iconsSlotGeometryimports no icons, so nothing to convert there.