Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A source that classifies its node but sends no 2525D entity code still says what kind of platform it is. The resolver now reads that specialization, between the entity code and the bare symbol-set dimension: an unmanned surface or subsurface system or ground system gets the table's symbol for it, a crewed vessel, aircraft or spacecraft gets its dimension, and a radar, CBRN or other sensor gets the table's sensor symbols. The specialization is ignored when it contradicts the symbol set. The set is the 2525 statement; a disagreement is an error at the source, and moving a sea track into the air dimension says something false rather than something less. Values the table cannot place are left out on purpose. Order is unchanged otherwise: vehicle class, then the entity code, then this, then the symbol set alone.
krital
force-pushed
the
feat/cot-specialization
branch
from
September 20, 2026 09:26
9c5e3ed to
2841812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A source that classifies its node but sends no MIL-STD-2525D entity code still says what kind of platform it is. Until now that went unused: such a twin fell straight through to the bare dimension of its symbol set, so an unmanned surface vehicle and the ship next to it both rendered as
a-f-S.The resolver now reads the node specialization, in the order it deserves — after the entity code, which is the finer statement, and before the symbol set alone:
SURFACE_UNMANNED_SYSTEMa-f-S-C-USUBSURFACE_UNMANNED_SYSTEMa-f-U-S-UGROUND_UNMANNED_SYSTEMa-f-G-U-C-V-USURFACE_VESSEL,VESSELa-f-SSUBSURFACE_VESSELa-f-UAIRCRAFT/SPACECRAFT/LAND_VEHICLEa-f-A/a-f-P/a-f-GRADARa-f-G-E-S-RCBRN_SENSORa-f-G-E-X-Na-f-G-E-STwo deliberate restraints:
OTHER,VEHICLE, and the sensing types with no physical counterpart. They say nothing the symbol set has not said already, and a crewed vessel gets its dimension only: it moves on the surface, which is not a claim that it is a combatant.Tests cover each mapping, both spellings of the value (the
$discriminatorand the object key alone), the precedence against the vehicle class and the entity code, the contradiction case, a twin with no description at all, and the unvalidated path when the type table is absent. 153 tests in the package pass.