Conversation
examples/extras/nli_e2e_example.py imports memos.extras.nli_model, which was deleted in the hook-based plugin refactor (MemTensor#1533) and no longer lives anywhere in the tree (or the memos-local plugin). The example raises ImportError on run, and it is the only file in examples/extras/.
Memtensor-AI
added
area:core
Collaborator
🤖 Open Code ReviewTarget: PR #2389 ✅ OpenCodeReview: Review skipped: no items were selected. Generated by cloud-assistant via Open Code Review. |
Collaborator
✅ Automated Test Results: PASSEDAll tests passed (1/1 executed). memos_github_open_source/smoke: 1/1. Duration: 1s Branch: |
Memtensor-AI
added
status:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/extras/nli_e2e_example.py imports:
but memos.extras.nli_model was deleted in the hook-based plugin-system refactor (#1533) and does not exist anywhere else in the tree (or in apps/memos-local-plugin). The example therefore raises ImportError on run, and it is the only file in examples/extras/.
Related Issue: N/A (dead-code cleanup after #1533)