Keep the soname symlinks of thirdparty libs in the .deb - #6932
Merged
Merged
Conversation
`cp -rL ./lib` dereferenced every symlink, so libz.so, libz.so.1 and libz.so.1.x were packaged as separate full copies and the postinst ldconfig warned "<lib>.so.N is not a symbolic link" for each of them (MeshInspector issue #141). Copy with `cp -a` and fail the packaging if any absolute or dangling symlink would ship. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI links ./lib to /usr/local/lib/meshlib-thirdparty-lib/lib, so `cp -a ./lib` packaged just that absolute link (caught by the new guard). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
distribution.sh keeps only the fix. A new CI step after Extract Deb prints the .deb size and fails on absolute or dangling symlinks, and on a regular file sitting under another library's soname - what ldconfig reports as "is not a symbolic link". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oitel
reviewed
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 1a23cde.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oitel
approved these changes
Sep 25, 2026
…y itself So MeshInspector can reuse it on its own packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/distribution.shcopied the thirdparty./libwithcp -rL, which dereferences symlinks:libz-ng.so,libz-ng.so.2andlibz-ng.so.2.xall ship as separate regular files. The postinstldconfigthen warns for every soname file that is not a symlink, e.g.(reported by a user in MeshInspector/MeshInspector#141 for libz, libopenvdb, libcpr, libE57Format). It also packages each such library two or three times.
distribution.sh: the contents of./libare copied withcp -a ./lib/., preserving the soname symlinks inside../lib/.rather than./libbecause CI's./libis itself an absolute symlink to/usr/local/lib/meshlib-thirdparty-lib/lib- that is what-Lwas covering for../includekeepscp -rL: headers are not seen by ldconfig.scripts/devops/check_deb_libs.sh <deb> <lib dir inside the package>, run by both ubuntu workflows afterExtract Deb(it extracts the package into a temp dir by itself, so MeshInspector can reuse it on its own.debs): prints the.debsize and fails on absolute or dangling symlinks in the packaged lib dir, and on a regular file sitting under another library's soname (read withreadelf) - exactly what ldconfig reports as "is not a symbolic link".Size
meshlib-dev.deb, master 954b15d (release artifact size) vs this PR:Verification
cp -rLtemporarily restored (1a23cde, reverted), the new check failed on all 7 ubuntu legs, listinglibcpr.so.1,libE57Format.so.3,libopenvdb.so.10.1,libz-ng.so.2- the same libraries as in the issue.dpkg --extractonly), so the absence of the ldconfig warning itself is inferred from the soname check.🤖 Generated with Claude Code