Conversation
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
/ok to test 7ec80f3 |
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
…0-20260922 Signed-off-by: seonjinn <sna@nvidia.com> # Conflicts: # nemo_rl/weight_sync/nccl_reshard_weight_synchronizer.py
…3908-mcore7300-20260922 Signed-off-by: seonjinn <sna@nvidia.com> # Conflicts: # nemo_rl/models/megatron/setup.py # tests/unit/models/megatron/test_megatron_setup.py # tests/unit/models/policy/test_megatron_worker.py # uv.lock
…3909-mcore7300-20260922
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
…0-20260922 Signed-off-by: seonjinn <sna@nvidia.com>
…0-20260922 Signed-off-by: seonjinn <sna@nvidia.com>
…3908-mcore7300-20260922 Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
…into codex/pr3909-mcore7300-20260922
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Contributor
Author
|
Additional GB200 validation completed on head Pinned dependencies:
Results:
All selected tests passed. The vLLM tests used a separate pinned environment because the repository intentionally marks the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native MXFP8 training stores each quantized parameter as E4M3 values plus E8M0 scales. vLLM refit must place both tensors into the model's existing parameter storage before the normal weight-processing step runs.
This PR adds a version-aware vLLM refit adapter and binds ordered components from #3907 to their live destinations:
The adapter restores loader-owned state before each refit, receives every component, runs vLLM's post-load processing once, and discards temporary state after success or failure.
What changes
draft.*weights stay on the external drafter path, co-trained MTP weights stay on the policy stream, and disk-loaded MTP weights are not overwritten.vLLM's layerwise finalizer already reprocesses attention modules, including static FP8 KV-cache scales, so this PR does not run a second full-model post-load pass.
Dependencies
Tests
fp8_param=true: W&B. That branch also contains lookup/selective-initialization optimizations not included in this update; it is not an exact-head validation of this PR. The port atfe415f92has not yet been rerun on GB200.git diff --checkpass locally. Full vLLM-backed tests are requested through CI.