Conversation
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
ssrowe and
tonygermano
September 20, 2026 00:06
pacmano1
previously approved these changes
Sep 20, 2026
pacmano1
left a comment
pacmano1
left a comment
Contributor
There was a problem hiding this comment.
Reverted just the JdbcDao hunk and ran ci/runtests.sh alpine-temurin21-oracle. 101-raw-no-op/01-hello-world fails with "Expected source encoded content but the server stored none", while the other assertions on that channel still pass. Fails without the fix, passes with it.
tonygermano
reviewed
Sep 21, 2026
A historical change set did not use the closeDatabaseObjectIfNeeded method which permits the oracle connections to batch inserts. Updated to use that. Non-oracle databases are not affected by this change since they do not override the closeDatabaseObjectIfNeeded method. Closes 454 Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
fix/oracle-message-history
branch
from
September 21, 2026 21:50
179d435 to
a1253a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A historical change set did not use the closeDatabaseObjectIfNeeded method which permits the oracle connections to batch inserts. Updated to use that.
Non-oracle databases are not affected by this change since they do not override the closeDatabaseObjectIfNeeded method.
Closes #454