test(forge): cover PR-create and comment response decode (RIG-3925) - #1330
Draft
rigel-mintaka wants to merge 2 commits into
Draft
rigel-mintaka wants to merge 2 commits into
rigel-mintaka wants to merge 2 commits into
Conversation
Adds TestForgeStubDecodesCreateResponses next to TestForgeStubProviderClient. It drives CreatePullRequest and CommentOnPullRequest against the loopback forge stub and compares the full decoded forge.PullRequest and forge.Comment values. The tier-2 agent-loop leg never renders these fields, so nothing asserted them before. The frozen six-turn leg is unchanged. The comment request body differs from the stub's fixed response body, so the Body assertion proves the value came from the response. Each of the 14 decoded fields was checked by zeroing it in ghPull.toPullRequest / ghComment.toComment; every mutation fails the test. Provider setup moves into a shared newForgeStubProvider helper, and both tests root their context in t.Context(). Spec-impact: none. Refs RIG-3925 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-forge-rig-3925-forge.compass-eng-docs.pages.dev Deployed from |
The leg renders the decoded PR number and URL, so the comment no longer claims it renders none of these fields. Refs RIG-3925 Co-authored-by: Matt Wilkinson <matt@rigel.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TestForgeStubDecodesCreateResponses next to TestForgeStubProviderClient. It drives CreatePullRequest and CommentOnPullRequest against the loopback forge stub and compares the full decoded forge.PullRequest and forge.Comment values. The tier-2 agent-loop leg never renders these fields, so nothing asserted them before. The frozen six-turn leg is unchanged.
The comment request body differs from the stub's fixed response body, so the Body assertion proves the value came from the response. Each of the 14 decoded fields was checked by zeroing it in ghPull.toPullRequest / ghComment.toComment; every mutation fails the test.
Provider setup moves into a shared newForgeStubProvider helper, and both tests root their context in t.Context().
Spec-impact: none. Refs RIG-3925
Co-authored-by: Matt Wilkinson matt@rigel.build