Conversation
DOM.describeNode only reports the target's own attributes. A paragraph inside [contenteditable] has none, so fill rejected it before the live isContentEditable check. Agents snapshot the inner block of rich editors and then cannot type into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bsk fillrejected a<p>(or other inner block) inside acontenteditableeditor withtarget_not_fillable.DOM.describeNodeonly reports the target's own attributes. Snapshot refs for TipTap, ProseMirror, Notion-style editors point at the inner paragraph, which has nocontenteditableattribute even thoughelement.isContentEditableis true. Fill never reached the live editability check.Change
Treat unknown tags as maybe-fillable so the live
isContentEditablecheck can accept inherited editability. Keep rejecting controls that fill cannot drive (button,select, media, and similar).Testing
pnpm --filter @browser-skill/extension exec vitest run src/tools/__tests__/fill.test.ts -t contenteditablepnpm --filter @browser-skill/extension testAI-assisted (Grok)