Skip to content

locales - add/backport Spanish (Andalusia) - #942

Open
timse201 wants to merge 1 commit into
WordPress:trunkfrom
timse201:patch-8
Open

timse201 wants to merge 1 commit into
WordPress:trunkfrom
timse201:patch-8

Conversation

@timse201

@timse201 timse201 commented Sep 25, 2026 •

Copy link
Copy Markdown

https://make.wordpress.org/polyglots/2023/03/12/locale-request-for-andaluh/

GlotPress/GlotPress@c358b48

Summary by CodeRabbit

  • New Features
    • Added support for Spanish (Andalusia) as a locale, with its regional names and language identifiers.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props timse201.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 393c785c-210e-48b7-8907-8aed4abd7fd8

📥 Commits

Reviewing files that changed from the base of the PR and between 41cb497 and 325d5ea.

📒 Files selected for processing (1)
  • wordpress.org/public_html/wp-content/mu-plugins/pub/locales/locales.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The locale registry adds Spanish (Andalusia), with English and native names, language codes, country code, WordPress locale, and slug.

Changes

Spanish (Andalusia) locale

Layer / File(s) Summary
Add locale definition
wordpress.org/public_html/wp-content/mu-plugins/pub/locales/locales.php
GP_Locales::__construct() adds the locale’s names, language codes, country code, WordPress locale, and slug.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 325d5

The change adds Spanish (Andalusia) to the locale registry for route registration and lookup. The reported indentation issue is disproven, and no concrete user-facing risk remains.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 325d5

The new locale becomes publicly reachable through existing routes. The inspected routes retain their locale and translation-set checks, with no identified security-control bypass. Other consumers and deployment behavior were not fully covered.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — Public requests can reach locale routes using the newly registered es-an slug. The inspected change is confined to the locale registry and its existing route consumers.

Trust Boundaries and Controls

  • observed — In the inspected handler, a request-supplied locale slug must resolve to a registered locale, and its translation-set slug must exist, before processing continues.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding or backporting the Spanish (Andalusia) locale.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant