Skip to content

Recognize Snowflake CLONE as a keyword - #910

Draft
Victor-Su-Ortiz wants to merge 1 commit into
andialbrecht:masterfrom
Victor-Su-Ortiz:minimax/snowflake-clone-678
Draft

Victor-Su-Ortiz wants to merge 1 commit into
andialbrecht:masterfrom
Victor-Su-Ortiz:minimax/snowflake-clone-678

Conversation

@Victor-Su-Ortiz

Copy link
Copy Markdown

Summary

Fixes #678.

Register CLONE in the Snowflake keyword table so it is not grouped as an alias of the new database name. Cover database, schema and table clones, mixed case, quoted names, statement type, formatting, and a statement without CLONE.

Verification

  • On the original implementation, six CLONE regression cases fail and the non-CLONE case passes.
  • With the patch, all seven regression cases pass.
  • Independently ran the full suite on Python 3.11: 513 passed, 2 xfailed, 1 xpassed.
  • Ruff and git diff --check: passed.
  • The implementation run also exercised Python 3.10–3.14 via make test; those logs are retained locally.

AI assistance

Implementation and initial tests were produced through OpenCode using opencode/space-bunny-free (Space Bunny). Codex reviewed the diff and independently ran the checks above. This draft has not received human code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CLONE keyword is being parsed as part of the Identifier

1 participant