perf(compute): vectorize mixed 64-bit filters - #1311
Open
fallintoplace wants to merge 2 commits into
Open
fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
zeroshade
reviewed
Sep 15, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
No SIMD data-path correctness issue found. Focused AVX2 kernel tests and compute filter tests passed, including the noasm fallback. ARM64 was inspected but not executed. One optional build-constraint correction below; this is not a runtime blocker.
| @@ -0,0 +1,79 @@ | |||
| //+build !noasm !appengine | |||
Member
There was a problem hiding this comment.
Non-blocking: the space in this legacy +build constraint means OR, so noasm-only and appengine-only builds still include this assembly source. go list -tags noasm -f '{{.SFiles}}' ./arrow/compute/internal/kernels confirms it. The Go caller is excluded, so it remains unreachable. Please match the uint32 sibling with //go:build go1.18 && amd64 && !noasm && !appengine and preserve the constraint during regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Benchmark
Apple M1 Pro, macOS arm64, Go 1.26.3. Median of five runs. The baseline uses GODEBUG=cpu.all=off.
The mixed-mask cases also go from 33 to 32 allocations per operation. The output allocation is still the main B/op cost.
Tests