Skip to content

IGNITE-28849 Fix calcite test 21jdk #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wernerdv merged 1 commit into from
Sep 23, 2026
+2 −44
Merged

IGNITE-28849 Fix calcite test 21jdk #13320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 2 additions & 44 deletions modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
import java.io.IOException;
import java.io.InputStream;
import java.lang.annotation.Annotation;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.VarHandle;
import java.lang.management.ManagementFactory;
import java.lang.ref.ReferenceQueue;
import java.lang.ref.SoftReference;
Expand Down Expand Up @@ -1819,35 +1817,10 @@ private static Object findField(Class<?> cls, Object obj,
*/
public static void setFieldValue(Object obj, String fieldName, Object val) throws IgniteException {
assert obj != null;
assert fieldName != null;

try {
Class<?> cls = obj instanceof Class ? (Class)obj : obj.getClass();
Class<?> cls = obj instanceof Class ? (Class)obj : obj.getClass();

Field field = cls.getDeclaredField(fieldName);

boolean isFinal = (field.getModifiers() & Modifier.FINAL) != 0;

boolean isStatic = (field.getModifiers() & Modifier.STATIC) != 0;

/**
* http://java.sun.com/docs/books/jls/third_edition/html/memory.html#17.5.3
* If a final field is initialized to a compile-time constant in the field declaration,
* changes to the final field may not be observed.
*/
if (isFinal && isStatic)
throw new IgniteException("Modification of static final field through reflection.");

boolean accessible = field.isAccessible();

if (!accessible)
field.setAccessible(true);

field.set(obj, val);
}
catch (NoSuchFieldException | IllegalAccessException e) {
throw new IgniteException("Failed to set object field [obj=" + obj + ", field=" + fieldName + ']', e);
}
setFieldValue(obj, cls, fieldName, val);
}

/**
Expand Down Expand Up @@ -1882,21 +1855,6 @@ public static void setFieldValue(Object obj, Class cls, String fieldName, Object
if (isFinal && isStatic)
throw new IgniteException("Modification of static final field through reflection.");

if (isFinal && U.majorJavaVersion(U.jdkVersion()) >= 12) {
MethodHandles.Lookup lookup = MethodHandles.privateLookupIn(Field.class, MethodHandles.lookup());

VarHandle varHandle = lookup.findVarHandle(Field.class, "modifiers", int.class);

varHandle.set(field, field.getModifiers() & ~Modifier.FINAL);
}
else if (isFinal) {
Field modifiersField = Field.class.getDeclaredField("modifiers");

modifiersField.setAccessible(true);

modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);
}

field.set(obj, val);
}
catch (NoSuchFieldException | IllegalAccessException e) {
Expand Down
Loading