[core] Update row-count defaults and rename global index file option - #10035
Open
leaves12138 wants to merge 2 commits into
Open
leaves12138 wants to merge 2 commits into
leaves12138 wants to merge 2 commits into
Conversation
leaves12138
changed the title
Contributor
|
Why modify this to file? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
data-evolution.reassign.skip-contiguous-row-countfrom 1 billion to 20 billion (20_000_000_000L).GLOBAL_INDEX_ROW_COUNT_PER_SHARDtoGLOBAL_INDEX_ROW_COUNT_PER_FILEand change its configuration key toglobal-index.row-count-per-file. Increase the default from 100,000 to 25,000,000 rows. The legacyglobal-index.row-count-per-shardkey remains a fallback; the new key takes precedence when both are set.Tests
mvn -B -ntp -pl paimon-api -DwildcardSuites=none -Dtest=GlobalIndexOptionsTest test— 3 tests passed, covering the default, legacy fallback, and new-key precedence.mvn -B -ntp -pl paimon-flink/paimon-flink-common,paimon-spark/paimon-spark-common -am -Pflink1,spark3 -DskipTests compile— passed, including Checkstyle and Spotless checks.PYTHONPATH=paimon-python python3 -m pytest -q paimon-python/pypaimon/tests/global_index_options_test.py paimon-python/pypaimon/tests/global_index_build_test.py::GenericIndexStreamingTest— 14 tests passed.git diff --check— passed.