[GH-1754] Clarify ST_MakeValid orientation and collapse behavior - #3386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Yes, I have read the Contributor Rules and Contributor Development Guide.
Is this PR related to a ticket?
Related to #1754.
What changes were proposed in this PR?
Document that ST_MakeValid may reorder coordinates or reverse polygon ring orientation, including for already-valid inputs. Explain how to apply ST_ForcePolygonCCW or ST_ForcePolygonCW after repair without implying that they restore the original vertex order.
Update the Spark, Flink, Snowflake and Python documentation, and correct reversed keepCollapsed descriptions in Flink, Snowflake and Python. Runtime behavior is unchanged.
How was this patch tested?
Did this PR include necessary documentation updates?
Yes, this PR updates API documentation and the Python docstring.