Skip to content

[GH-1754] Clarify ST_MakeValid orientation and collapse behavior - #3386

Merged
jiayuasu merged 2 commits into
apache:masterfrom
jiayuasu:codex/gh-1754-makevalid-docs
Sep 22, 2026
Merged

jiayuasu merged 2 commits into
apache:masterfrom
jiayuasu:codex/gh-1754-makevalid-docs

Conversation

@jiayuasu

Copy link
Copy Markdown
Member

Did you read the Contributor Guide?

Yes, I have read the Contributor Rules and Contributor Development Guide.

Is this PR related to a ticket?

Related to #1754.

What changes were proposed in this PR?

Document that ST_MakeValid may reorder coordinates or reverse polygon ring orientation, including for already-valid inputs. Explain how to apply ST_ForcePolygonCCW or ST_ForcePolygonCW after repair without implying that they restore the original vertex order.

Update the Spark, Flink, Snowflake and Python documentation, and correct reversed keepCollapsed descriptions in Flink, Snowflake and Python. Runtime behavior is unchanged.

How was this patch tested?

  • Applicable repository hooks and whitespace checks passed.
  • Bilingual MkDocs build passed, and the generated reference pages were checked. Existing missing generated-API documentation and link warnings remain.
  • Local Spark 3.4.4 probes confirmed the collapsed-line results with default/true keepCollapsed and CCW orientation after repair with unchanged topology. These used an existing Sedona snapshot JAR, not a fresh JVM build of this commit.

Did this PR include necessary documentation updates?

Yes, this PR updates API documentation and the Python docstring.

@jiayuasu jiayuasu added this to the sedona-2.0.0 milestone Sep 22, 2026
@jiayuasu jiayuasu linked an issue Sep 22, 2026 that may be closed by this pull request
@jiayuasu
jiayuasu merged commit 36140b3 into apache:master Sep 22, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ST_MakeValid changes the order of points in a polygon

1 participant