feat: add unrestricted HexGraph VR skill - #308
Conversation
Generate and install an additive companion that invokes the restricted VR skill, permits authorized external analysis tools, and keeps HexGraph as the durable research ledger.
|
REQUEST-CHANGES I completed both merge-gate passes against Blocking finding
Other review results
Verification: focused generator/installer/setup/refresh/MCP/delegate tests passed ( |
Clarify that HexGraph operations remain sandboxed while separately authorized companion tools do not inherit those guarantees. Addresses merge-gate review discussion_r3787877897.
branover
left a comment
There was a problem hiding this comment.
APPROVE
Independent merge-gate review completed against PR head 512ed9222f3b55ef019afc48f2df4261ca58e932, using both gh pr diff 308 and git diff origin/main...HEAD.
The one blocking finding from my initial review is fixed in 512ed92: README and CLAUDE.md now scope HexGraph's sandbox, feature-gate, and Observation guarantees to operations performed through HexGraph, explicitly describe companion-driven external tooling as a separately authorized path outside those guarantees, and retain restricted delegate mode on the primary skill. The inline thread is resolved.
No remaining correctness, test-quality, security-invariant, compatibility, documentation, migration, or UX-contract findings.
Verification:
- focused generator, installer, setup, refresh, MCP, and delegate coverage:
140 passed, 1 skipped - generated
hexgraph-vrandhexgraph-vr-companion: Skill Creatorquick_validate.pypassed for both git diff --check origin/main...HEAD: passed- GitHub and local diff file sets match at 13 files; worktree is clean and PR head matches the pushed commit
Security pass: no loopback-binding, secret, target-byte execution, network, rehosting, policy-seam, model, or migration implementation changed. The companion requires operator authorization, approved target access, suitable hostile-input isolation, approved data handling, and honest provenance; it does not claim to disable HexGraph gates or override higher-priority policy. full_skill_markdown() and agent_delegate.delegate_prompt() remain restricted to the unchanged primary bundle.
Use hexgraph-vr-unrestricted consistently across generated metadata, installers, tests, documentation, and the security contract.
branover
left a comment
There was a problem hiding this comment.
APPROVE
Independent final-head merge-gate review completed against d6ad7859db312f6686a9ff291f04e2784233ca8d using both gh pr diff 308 and git diff origin/main...HEAD.
No correctness, test-quality, security-invariant, compatibility, documentation, migration, or UX-contract findings remain.
Final rename audit:
hexgraph-vr-unrestrictedis consistent across generated directory names, YAML frontmatter, OpenAI metadata/default prompt, exported Python identifiers, CLI/setup/refresh installers, tests, README, MCP/setup docs, andCLAUDE.md.- The final tracked tree and generated output contain no
hexgraph-vr-companionreference. - Legacy
write_skill()compatibility remains intact: it emits both siblings and still returns the primaryhexgraph-vr/SKILL.mdpath. full_skill_markdown()remains the restricted primary bundle, andagent_delegate.delegate_prompt()still consumes only that bundle and forbids touching the binary by any other means.
Security pass:
- No loopback-binding, secret-handling, execution, network, rehosting, policy-seam, target-byte implementation, model, or migration code changed.
- Operations requested through HexGraph remain subject to its sandbox and feature gates. The unrestricted skill describes external tools as a separate operator-authorized path, requires an approved target copy and suitable hostile-input isolation, forbids exfiltration and host execution merely to avoid a gate, preserves higher-priority policy, and does not claim HexGraph sandbox or Observation guarantees.
- The earlier security-documentation finding remains fixed: README and
CLAUDE.mdscope HexGraph guarantees precisely and explicitly retain restricted delegate mode.
Independent verification:
- focused generator, installer, setup, refresh, MCP, and delegate suite:
140 passed, 1 skipped - Skill Creator
quick_validate.py:Skill is valid!for bothhexgraph-vrandhexgraph-vr-unrestricted git diff --check origin/main...HEAD: passed- GitHub and local final diff file sets match at 13 files; worktree is clean and the pushed PR head matches
d6ad785
The PR reports the full offline tier green at 1,843 passed, 47 skipped, 14 deselected; required CI is the remaining merge gate and is owned by the dispatcher.
Summary
hexgraph-vr-unrestrictedbeside the existinghexgraph-vrskillSafety and compatibility
write_skill()API still returns the primary path while emitting both skillsVerification
quick_validate.pygit diff --checkThe host-global Docker-enabled run additionally reached 1,885 passes before one unrelated live HTTP fixture failed because its test container was unreachable from the host; the isolated rerun reproduced that environment networking failure before application behavior.