chore: reduce noise created by key-contact migration - #8741
Merged
Merged
Conversation
link2xt
marked this pull request as ready for review
September 23, 2026 20:11
Stop logging the time migration takes
and don't log anything when migration runs on a fresh database
and only creates empty tables.
Without these changes every time profile is created,
the following info lines are logged:
src/sql/migrations.rs:35: Starting key-contact transition.
src/sql/migrations.rs:82: Not yet configured, no need to migrate key-contacts
src/sql/migrations.rs:1942: key-contacts migration took 1.143721ms in total.
link2xt
force-pushed
the
link2xt/no-key-contact-logs
branch
from
September 23, 2026 20:12
472fdae to
0d8e9c4
Compare
Hocuri
approved these changes
Sep 24, 2026
Hocuri
left a comment
Hocuri
left a comment
Collaborator
There was a problem hiding this comment.
Good to clean up the logs a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop logging the time migration takes
and don't log anything when migration runs on a fresh database and only creates empty tables.
Without these changes every time profile is created, the following info lines are logged: