Conversation
Member
|
Thank you for the PR! This looks like something we ought to contribute to VS Code itself rather than maintaining as a patch here. Could we send this up to https://github.com/microsoft/vscode? |
Contributor
Author
Thanks for the feedback! I completely agree — this is better suited to VS Code itself rather than being maintained as a patch here. I'm happy to send it upstream to https://github.com/microsoft/vscode. I'll open a PR/issue there and link back to this discussion. Do you want me to close this PR in the meantime, or keep it open until the upstream change is merged? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run buildnpm run gulp compile-webnpm run compile-clientmarkdown.stylesis applied correctly.The targeted Playwright E2E test is currently blocked before the workbench loads by an unrelated CSS module MIME-type issue in the development build.
Fixes #7913