fix: remove whitespace before semicolon in browser.js and fix CITGM packaging issues - #1058
Open
abhayagarwal-dev wants to merge 1 commit into
Open
abhayagarwal-dev wants to merge 1 commit into
abhayagarwal-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
A stray space before the semicolon at
src/browser.js:222causes asemi-spacinglint error, makingnpm run lintexit non-zero and failing CITGM runs on s390x (Node.js v20.11.0).Fixes
src/browser.js:222: Remove stray space before semicolon to fix thesemi-spacinglint errorpackage.json(files) :test.jsandtest.node.jswere not included in the published tarball; CITGM installs from the tarball so mocha had no test files to run, causing an immediate failurepackage.json(testscript) :test:browserrequires a Chrome binary; on headless environments like s390x, karma launches and hangs indefinitely waiting for a browser connection. Browser tests remain available vianpm run test:browserTesting
npm run lint: 0 errorsnpm test: 16/16 passingnpm run test:browser: 14/14 passing