JIT: Preserve exceptions during jump threading - #134279
Merged
AndyAyersMS merged 1 commit intoSep 21, 2026
Merged
AndyAyersMS merged 1 commit into
AndyAyersMS merged 1 commit into
Conversation
Jump threading could bypass exceptions from a redundant comparison. Require the dominating comparison to cover the removed exception set. Fixes dotnet#133982 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2f9acea8-450d-4bad-8278-b5a324b6f655
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
@EgorBo PTAL minimal (~40) spmi diffs |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrowly scoped guard matches the existing exception-set contract and the regression test directly covers the lost exception.
Review effort: Lite
Findings: None
What changed in this PR
Fixes RyuJIT jump threading so exception-producing comparisons are not incorrectly removed.
Changes:
- Validates dominating and dominated exception sets before threading.
- Adds a
DivideByZeroExceptionregression test.
| File | Description |
|---|---|
src/coreclr/jit/redundantbranchopts.cpp |
Preserves uncovered exceptions during jump threading. |
src/coreclr/jit/compiler.h |
Updates the helper signature. |
src/tests/JIT/opt/RedundantBranch/RedundantBranchDominating.cs |
Adds regression coverage. |
EgorBo
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DivideByZeroExceptionTesting
RedundantBranchDominating: 7 tests passedDivideByZeroExceptionResolves #133982
Note
This pull request description was generated with GitHub Copilot.