Conversation
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot
AI
changed the title
ci(gitlab): add manifest created annotations
Add created-time OCI annotations to GitLab manifest publishing
Sep 17, 2026
Copilot created this pull request from a session on behalf of
wdconinc
September 17, 2026 04:04
View session
wdconinc
marked this pull request as ready for review
September 17, 2026 04:07
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new --annotation compatibility guard can mask real docker buildx failures as “flag unsupported”, which undermines the stated goal of failing early with a clear error.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates the GitLab CI manifest-publishing jobs to ensure manifests produced via .gitlab-ci.yml include a consistent OCI org.opencontainers.image.created timestamp, improving metadata completeness across published tags.
Changes:
- Add a
CI_PIPELINE_CREATED_AT-basedorg.opencontainers.image.createdannotation (with UTC fallback) todocker buildx imagetools createcalls in both manifest jobs. - Add an early guard that checks whether
docker buildx imagetools createsupports--annotationand fails the job otherwise.
File summaries
| File | Description |
|---|---|
| .gitlab-ci.yml | Adds created-time OCI annotations to manifest tag publishing in base-manifest and eic-manifest, with a buildx compatibility guard. |
Review details
Suppressed comments (1)
.gitlab-ci.yml:487
- Same issue as
base-manifest: the--help | greppipeline can turn a realdocker buildxfailure into a misleading “does not support --annotation” error. Check that the help command succeeded first, then test for the flag (and write errors to stderr).
docker buildx imagetools create --help | grep -q -- '--annotation' || { echo "ERROR: docker buildx imagetools create does not support --annotation"; exit 1; }
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| script: | ||
| - apk add bash jq | ||
| - | | ||
| docker buildx imagetools create --help | grep -q -- '--annotation' || { echo "ERROR: docker buildx imagetools create does not support --annotation"; exit 1; } |
veprbl
approved these changes
Sep 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitLab manifest jobs were publishing tags without a creation-time annotation. This updates both manifest paths so images created from
.gitlab-ci.ymlcarry a consistentorg.opencontainers.image.createdtimestamp.Manifest annotation coverage
--annotation "index:org.opencontainers.image.created=..."to everydocker buildx imagetools createinvocation in:base-manifesteic-manifestTimestamp source
CI_PIPELINE_CREATED_ATas the primary timestamp so tags produced by the pipeline share the same creation time.Compatibility guard
docker buildx imagetools createdoes not support--annotation, instead of silently publishing unannotated manifests.Example of the change pattern: