runtimes/go: add metrics.SetServiceLabels for per-service label enrichment - #2394
Open
twindebank wants to merge 1 commit into
Open
twindebank wants to merge 1 commit into
twindebank wants to merge 1 commit into
Conversation
twindebank
force-pushed
the
service-labels-v2
branch
from
April 10, 2026 12:27
42634cc to
1bbea2b
Compare
…tom labels Add metrics.SetServiceLabels(serviceName, labels) which registers additional labels to be included with all metrics exported for a given service. This enables enriching Encore's built-in metrics (like e_requests_total) with custom metadata such as domain, team, or cost-center labels. Labels are stored in the Registry, attached to CollectedMetric at collection time, and applied by each exporter (Prometheus, GCP, Datadog, CloudWatch) when the service name is resolved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
twindebank
force-pushed
the
service-labels-v2
branch
from
April 10, 2026 12:30
1bbea2b to
53a8b7e
Compare
bkach
approved these changes
Apr 15, 2026
bkach
left a comment
There was a problem hiding this comment.
Adding service labels makes sense, nice one!
bkach
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
metrics.SetServiceLabels(serviceName, labels)which registers additional labels to be included with all metrics exported for a given service. This enables enriching built-in metrics (likee_requests_total) with custom metadata without duplicating the metric pipeline via OTel.All four exporters are updated (Prometheus, GCP Cloud Monitoring, Datadog, CloudWatch). Reserved keys and empty values are filtered at registration time.