fix(daemon): stop ResourceManager upon Test completion to prevent resource leaks - #2571
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Author
|
Hi, friendly ping for review on this PR when you have a moment. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
encore testis executed,Manager.Test()callsmgr.testSpec()which initializes a newinfra.ResourceManagerviainfra.NewResourceManager(..., forTests: true)and callsrm.StartRequiredServices(jobs, parse.Meta)to boot ephemeral test infrastructure (such as local NSQ pubsub daemons or local redis).Unlike
ExecScript(which defersrm.StopAll()) andRun.Stop()(which terminates its resource manager),Manager.Test()did not capture or stop theResourceManagerafter test execution finished or failed.As a result, long-running daemon processes leak child processes (
nsqd,miniredis) and file descriptors across repeated test runs.Solution
mgr.testSpec()to return(*builder.TestSpecResult, *infra.ResourceManager, error).defer rm.StopAll()inManager.Test()once the test execution finishes or errors out.rm.StopAll()intestSpecerror return paths (jobs.Wait(),ServiceConfigs,ForTests,TestSpec).Verification
go vet ./cli/daemon/run/...runs cleanly.cli/daemon/run/exec_script.go:69.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.