Conversation
tmccoy14
left a comment
There was a problem hiding this comment.
Reviewed the scroll-area deprecation across all 3 commits. The removal itself is clean and complete — both CSS entry points updated, no lingering references to the deleted utilities in source or built CSS, and Dialog/Sheet still scroll correctly since .dialog-body and .sheet-body already carry overflow-auto. The docs plumbing works too: llms.txt and the .md twins render the deprecation as intended. lint, format:check, and the full build all pass.
Three things to fix in the CHANGELOG before merging, noted inline.
| ### Changed | ||
|
|
||
| - `DialogBody` and `SheetBody` scroll with the native scrollbar rather than the removed utility class. | ||
| - The `equality-design-system` skill tells agents to use native scroll containers and not to restyle scrollbars. |
There was a problem hiding this comment.
This claims a change that isn't in the branch. grep -rni "scrollbar|scroll area|overflow" packages/skills/ returns nothing — the equality-design-system skill is untouched.
This is the gap CLAUDE.md specifically calls out: the skill is what stops agents in other repos rebuilding what we already ship. Without it, an agent consuming the skill still has no rule against hand-rolling ::-webkit-scrollbar styling. The "Common Mistakes" list in packages/skills/equality-design-system/SKILL.md is the natural home for it.
Either add the guidance to the skill, or drop this line.
|
|
||
| ### Changed | ||
|
|
||
| - `DialogBody` and `SheetBody` scroll with the native scrollbar rather than the removed utility class. |
There was a problem hiding this comment.
DialogBody and SheetBody aren't exported — there are no such names anywhere in packages/ui/src. The components actually changed are DialogContent and SheetContent (they consume the dialog-body / sheet-body CSS module classes, which is probably where the naming came from).
| @@ -0,0 +1,21 @@ | |||
| # Changelog | |||
|
|
|||
| Notable changes to Explorer are recorded here, following [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). | |||
There was a problem hiding this comment.
"Explorer" should be "Equality". Worth catching since this file was added to files in package.json, so it now ships to npm and renders on the package page.
|
Heads up on downstream impact:
Nothing breaks on merge — studio pins Three of the five are the straightforward
Not a blocker for this PR — just flagging so the studio migration gets tracked rather than discovered at the next version bump. |
These are left over from the component library conversion and not elements that I want to have stick around! Deprecating in favour of browser-native scroll controls (which we use almost everywhere anyways). Now that we have a skill which gives agents a lot of context on our components, it's becoming more important to clean this stuff up so it doesn't get implemented more widely.
Also adds a changelog going forward for the component library.