Skip to content

Add additional organization billing information to the Svelte billing settings - #2275

Draft
niemyjski with Copilot wants to merge 18 commits into
mainfrom
copilot/add-billing-information-support
Draft

niemyjski with Copilot wants to merge 18 commits into
mainfrom
copilot/add-billing-information-support

Conversation

Copilot AI commented May 31, 2026

Copy link
Copy Markdown
Contributor

Organizations can save a billing name, address, VAT ID, and VAT number from Svelte billing settings. The form reuses existing organization data keys and endpoints; clearing a field removes its key. Invoice history retains its amounts, payment statuses, and actions.

Autosaves and individual key writes run sequentially to preserve edits made during saves and avoid overwriting sibling values in the backend's whole-document updates. Navigation waits for pending changes, and failed saves retain input for retry. Latest main is integrated without additional feature or API changes. The website workflow uses Deno 2.9.7 because its previous 2.5.7 pin cannot load the current Lume dependency.

Validation: 821 frontend tests passed; formatting, lint, Svelte checks (zero errors/warnings), production build, Storybook build, and website Deno verification passed. Desktop/mobile billing scenarios passed twice each against a local production build with mocked API responses.

Remaining gates: full-stack local persistence verification is pending; fresh hosted checks must finish, and the existing Copilot CLA check remains unresolved. This PR remains draft.

Verification details
  • Browser scenarios cover all four fields, reload, clearing/deleting a key, preserving unrelated data, save failure/retry, and navigation before and during saves at 1440px and 390px.
  • An initial development-mode mobile run was interrupted by a Storybook-triggered Vite reload. Three mobile reruns and all four stable production-build runs passed.
  • Invoice tests cover amounts/status presentation, opening invoices, and empty/loading/error states.
  • No review threads or submitted reviews were outstanding when inspected.
  • Mocked browser tests establish frontend behavior, not backend persistence. Existing API routes, authorization, response types, and stored keys are unchanged.

Copilot AI linked an issue May 31, 2026 that may be closed by this pull request
@CLAassistant

CLAassistant commented May 31, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ejsmith
✅ niemyjski
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Add support for additional billing information Add additional organization billing information to the Svelte billing settings Jun 1, 2026
Copilot AI requested a review from niemyjski June 1, 2026 00:23
@ejsmith
ejsmith force-pushed the copilot/add-billing-information-support branch from a5bb43a to 9916b93 Compare June 28, 2026 01:24
@niemyjski

Copy link
Copy Markdown
Member

Follow-up reviewer-feedback and thermo-nuclear audit completed against live head e93c6879c3d0309d7024b4d8d510e42eaa654eb3 and origin/main dc940dd15c8d222d9764080622fdf4583d4546b8.

Feedback inventory and classification:

  • GraphQL review threads: 0 total / 0 unresolved.
  • Inline review comments: 0.
  • Submitted reviews: 0.
  • Top-level comments: the coverage report is informational and green; the CLA Assistant notice is an external gate because the Copilot committer cannot sign the CLA. There is no human, Codex, or Copilot code-review finding outstanding at the current live head.

Thermo-nuclear findings:

  • No remaining structural blocker or justified code change was found in the complete branch-vs-main diff.
  • The invoice table is isolated in an 89-line presentational component with populated/empty/loading/error Storybook states; the billing route is 301 lines and no changed file crosses 1,000 lines.
  • Serialized autosaves prevent older responses from overwriting newer input.
  • Per-key writes intentionally remain sequential: the backend handlers load and save the whole organization document per request, so parallel sibling-key writes can lose updates. This is correctness orchestration, not incidental serialization.
  • Missing/malformed legacy data normalizes safely, cleared values delete their stable keys, generic API access remains organization-scoped, and no API contract changed.
  • The PR description’s stale test filenames and unsupported backend-test claim were corrected.

Verification:

  • Focused Vitest: 3 files / 11 tests passed.
  • npm run check: 0 errors / 0 warnings.
  • npm run build: passed.
  • npm run build-storybook: passed.
  • git diff --check origin/main...HEAD: passed.
  • Build workflow 30205531546: API, client, E2E, Docker, and version passed.
  • Website workflow 30205531465: passed.

No commit was needed for this follow-up audit. The PR is code-ready and GitHub reports it mergeable; the remaining gates are the existing draft state and pending Copilot CLA.

@niemyjski
niemyjski force-pushed the copilot/add-billing-information-support branch from 87ba6f8 to 356c79f Compare September 16, 2026 00:39
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286
Exceptionless.Web 85% 70% 8108
Exceptionless.Core 76% 68% 10538
Exceptionless.AppHost 38% 41% 147
Summary 79% (26389 / 33396) 68% (12275 / 18049) 19079

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for additional billing information

4 participants