Skip to content

Add supported stack sort controls to the Svelte UI - #2278

Open
niemyjski with Copilot wants to merge 10 commits into
mainfrom
copilot/make-more-columns-sortable
Open

niemyjski with Copilot wants to merge 10 commits into
mainfrom
copilot/make-more-columns-sortable

Conversation

Copilot AI commented May 31, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Added descending Events and Last controls to the Svelte stack table. The selected order survives reloads and saved views; changing it resets pagination and row selection. Legacy -events and -last values stay intact when saving unrelated settings, including when the same value appears explicitly in the URL.

Why

The stack API supports these ordering modes but rejects generic sort parameters. Normalizing only when deriving the API mode preserves saved-view equality and avoids rewriting a legacy alias. First and session Duration remain non-sortable because the API cannot sort those columns without changing the result set or sorting just one page.

Verification

  • Frontend: 97 files and 808 unit tests passed; npm run validate reported zero errors or warnings; production build passed.
  • Hosted checks passed on 403498492: API, client, Docker build, and E2E. All five stack-sorting browser scenarios passed, including both explicit legacy URL aliases.
  • git diff --check passed. No backend API, dependency, or breaking changes.

Remaining gate

The contributor CLA check is pending. Local service-backed dogfooding remains queued for exclusive Aspire runtime access; hosted E2E provided browser coverage for the changed flow.

@CLAassistant

CLAassistant commented May 31, 2026 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ niemyjski
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI linked an issue Jun 1, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add sortable columns for users, frequent, and session events Enable sortable First/Last/Events stack columns and session Duration in Svelte tables Jun 1, 2026
Copilot AI requested a review from niemyjski June 1, 2026 00:27
@niemyjski niemyjski changed the title Enable sortable First/Last/Events stack columns and session Duration in Svelte tables Add supported stack sort controls to the Svelte UI Jul 10, 2026
@niemyjski
niemyjski marked this pull request as ready for review July 10, 2026 19:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6d3929e96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@niemyjski

Copy link
Copy Markdown
Member

Follow-up reviewer-feedback and thermo-nuclear audit completed against live head 8fa187e3b11e937702df62808185c67f1e7de0e3.

Feedback classification:

  • The Codex First-sort finding was valid for reviewed commit b6d3929e96, but is already fixed, outdated, and resolved on the current head. RCA: API mode stack_new calls AddFirstOccurrenceFilter, so it changes stack membership/count instead of only ordering the current rows. The current implementation excludes stack_new from StackSortMode, leaves First as plain non-interactive text, and exposes only stack_frequent (Events) and stack_recent (Last). Focused coverage locks that contract.
  • The submitted Codex review contains no other findings. There are no human change-request reviews or open review threads.
  • The coverage comment is informational; the CLA comment is an external contribution-policy blocker, not a code finding.

The complete five-file branch-vs-main diff also passed the requested thermo-nuclear structural review: no spaghetti/branch growth, boundary leak, duplicate canonical helper, cast/optionality churn affecting correctness, non-atomic update, unnecessary sequential orchestration, or 1,000-line threshold crossing. The 19-line header component earns its boundary by centralizing and testing the accessible pressed-state interaction; no safe code-judo simplification remains beyond removing the unsupported First mode.

Verification on the live head:

  • focused Vitest: 2 files, 6 tests passed
  • npm run validate: passed; Svelte check reports 0 errors and 0 warnings, formatting and ESLint clean
  • npm run test:unit: 29 files, 327 tests passed
  • npm run build: passed
  • git diff --check origin/main...HEAD: clean
  • executable CI checks version, test-client, docker-build, test-e2e, and test-api: all successful

No follow-up code change was required. The sole remaining blocker is the pending external Copilot contributor CLA.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69b976ee9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97ebf34593

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated
@niemyjski
niemyjski force-pushed the copilot/make-more-columns-sortable branch from 976b251 to 07f054e Compare September 16, 2026 00:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T03:19:33.317254Z 4034984 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07f054e3f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(app)/stack/+page.svelte Outdated
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Insulation 37% 35% 286 ❌
Exceptionless.Web 85% 70% 8108 ✔
Exceptionless.Core 76% 68% 10538 ✔
Exceptionless.AppHost 38% 41% 147 ❌
Summary 79% (26371 / 33396) 68% (12262 / 18049) 19079 ✔

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make more columns sortable

3 participants