Conversation
Update the OpenAPI schema URL. `curl` ran without `-f`, so an HTTP error was written to the output file and the script still exited 0. This change fix it. Use an `env bash` shebang and `set -euo pipefail`. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect the curl flags into `CURL_OPTS`, gated on `TRACE` and `ACTIONS_STEP_DEBUG` so runs can be made verbose, and harden them: fail on HTTP errors, retry transient failures, refuse redirects that leave https, and bound connect and transfer time so a stalled download cannot hang CI or a local run. Log the download. Related-Task: INTER-2472
|
pnpm exec changesetto create a changeset. |
Coverage report
Test suite run success137 tests passing in 12 suites. Report generated by 🧪jest coverage report action from 2e70c32 Show full coverage report
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Failed partial transfers can overwrite the existing schema, and the upstream rename remains incomplete.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates schema synchronization for the planned OpenAPI repository rename and improves download reliability.
Changes:
- Uses the renamed GitHub Pages schema URL.
- Adds retries, timeouts, HTTPS-only redirects, and optional diagnostics.
- Resolves output paths relative to the repository root.
| File | Description |
|---|---|
sync.sh |
Hardens and relocates the OpenAPI schema download. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Warning
Do not merge this PR until fingerprintjs/fingerprint-pro-server-api-openapi#480 merged and the repository renamed.
GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so
sync.shwill start failing after the rename. This PR changes the default OpenAPI schema URL.curlran without-f, which made that failure silent. With-fthe same request exits 56 and leaves the existing file untouched.Alongside the URL change, use
env bashshebang andset -euo pipefail. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect thecurlflags intoCURL_OPTS, gated onTRACEandACTIONS_STEP_DEBUGso runs can be made verbose, and harden them to fail on HTTP errors, retry transient failures, refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hang CI or local. Log the download.