Conversation
…y locale they name
…ery locale they name
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates various resource files to include new strings for re-authentication, MFA management, and profile completion. The reviewer identified that the Bengali translation file (values-bn/strings.xml) contains Hindi (Devanagari) text instead of the correct Bengali translations. I have kept these comments as they point out a critical localization issue that needs to be addressed.
demolaf
marked this pull request as ready for review
September 21, 2026 15:55
demolaf
marked this pull request as draft
September 21, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translates the 43
MissingTranslationstrings held inauth/lint-baseline.xmlacross all 84 locale folders, then deletes the baseline and itsbaseline =line. No module in the repo declares a baseline any more, and./gradlew lintAllis green without it.Changes
fui_loading_*strings take their progressive form fromfui_progress_dialog_signing_inrather than a guess.fui_sms_terms_of_service_and_privacy_policy_extendedwas translated everywhere by "Translations for 4.0"; feat: Error Recovery & Dialog #2225 deleted one line fromvalues-koalone, restored here verbatim.tools:ignore="UntranslatedResource"sites, allAccount: %1$sin languages where "account" is the word, each carrying its reason.values/strings.xmloverride comment moves belowfui_error_user_disabled, which is live translatable copy rather than one of the empty hooks it describes.Verified across 43 strings and 84 folders: no missing entries, no malformed XML, no placeholder drift, and no unsuppressed value identical to base English outside the seven
values-en-r*folders the check skips.Maintainer note: Fixes internal CPRN-483