feat(js): Offer dataCollection setup step SDK v11 that writes a PII-reducing preset into Sentry.init - #1359
Merged
Conversation
Adds src/utils/data-collection.ts: a v11 gate (sdkSupportsDataCollection), a yes/no prompt with telemetry (askShouldReduceDataCollection), and a renderer for the PII-reducing dataCollection preset with deny lists (getDataCollectionSnippet). Also hoists the duplicated private getMajor helpers from sveltekit and react-router into src/utils/semver.ts as getMajorVersion.
Prompts after install when the installed major is >= 11 and threads the decision through ProjectInfo into the hooks templates, the instrumentation.server template, and both magicast init-insert paths. When accepted, the commented-out dataCollection hint is replaced by the active preset; when declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Threads the decision into the server/edge config templates, the instrumentation-client file, and the copy-paste snippets. When accepted, the commented-out dataCollection hint is replaced by the active preset; when declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Re-reads the installed SDK version after install and threads the decision into the client and server config templates. When accepted, the commented-out dataCollection hint is replaced by the active preset; when declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Re-reads the installed SDK version after install and splices the active preset (with its comment block) into the magicast-generated client and server init calls when accepted. When declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Threads the decision into the server instrumentation template, the manual copy-paste snippets, and the client entry codemod. When accepted, the commented-out dataCollection hint is replaced by the active preset; when declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Re-reads the installed SDK version after install and splices the active preset (with its comment block) into the magicast-generated Sentry.init call when accepted. When declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Re-reads the installed SDK version after install and threads the decision into the worker template and the recast withSentry config builder (preset comment attached as leading comments). When declined, output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-reducing preset into `Sentry.init`
Base automatically changed from
sig/data-collection-setup-1-utils
to
master
September 22, 2026 14:23
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+171
to
+173
| const reduceDataCollection = | ||
| sdkSupportsDataCollection(installedSdkVersion, '^10.73.0') && | ||
| (await askShouldReduceDataCollection()); |
There was a problem hiding this comment.
Bug: The data collection prompt is never shown because the sdkSupportsDataCollection check requires SDK version 11+, but the wizard installs version 10.
Severity: LOW
Suggested Fix
Update the sdkSupportsDataCollection check to be compatible with the installed SDK version, or update the wizard to install version 11 or greater of the @sentry/nextjs package to ensure the data collection prompt is shown.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/nextjs/nextjs-wizard.ts#L171-L173
Potential issue: The data collection prompt, controlled by
`askShouldReduceDataCollection`, is never shown to users of the Next.js wizard. The
function `sdkSupportsDataCollection` checks if the installed `@sentry/nextjs` SDK major
version is 11 or greater to determine if the prompt should be displayed. However, the
wizard installs version `^10.73.0`, which always resolves to a major version of 10. As a
result, the condition `sdkMajor >= 11` is always false, preventing the prompt from ever
appearing.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d08bf2c. Configure here.
chargome
approved these changes
Sep 22, 2026
JPeer264
approved these changes
Sep 23, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Should we maybe add a link into the terminal with "More info: "?
Adds a "More info: <docs link>" line to the reduce-data-collection prompt so users can read up on the categories before deciding. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-setup-2-wizard-usage # Conflicts: # src/nuxt/nuxt-wizard.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every framework change lives in its own commit (easier reviewing).
Depends on (merged) #1358
Closes getsentry/sentry-javascript#24551