Conversation
github-actions
Bot
changed the base branch from
main
to
nikpivkin/advisory-improvement-9631
September 19, 2026 15:10
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The repository reference must use the PACKAGE type for consistent machine-readable classification.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates the sanitize-html advisory to correct affected-version metadata and add its source repository.
Changes:
- Removes the stale affected-version limit.
- Adds the current source repository reference.
- Updates the modification timestamp.
| File | Description |
|---|---|
GHSA-xc6g-ggrc-qq4r.json |
Corrects advisory metadata and adds the repository URL. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "url": "https://github.com/advisories/GHSA-xc6g-ggrc-qq4r" | ||
| }, | ||
| { | ||
| "type": "WEB", |
Author
There was a problem hiding this comment.
Agreed, it should be PACKAGE. I filled the "Source code location" field in the form, and the form saved it as WEB. I opened #9634 about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The range should be < 1.11.4, not <= 1.11.1.
The fix is apostrophecms/sanitize-html@5d205a1. The repository has no tags for 1.11.2 and 1.11.3, so I checked the npm packages. In 1.11.1, 1.11.2 and 1.11.3, index.js still has the old check "if (nonTextTagsArray.indexOf(tag) !== -1)". Version 1.11.4 is the first one with the fixed check "if ((tag === 'script') || (tag === 'style'))".
So versions 1.11.2 and 1.11.3 are still vulnerable but are outside the current range.
I also added the source code location. The vulnerable versions, the fix commit and issue #100 are in apostrophecms/sanitize-html, the old punkave/sanitize-html redirects there. Other sanitize-html advisories from 2021 to 2025 use the same location.