Conversation
README.md's How-it-works list described the API proxy sidecar as optional, but the CLI, awf-config-spec.md, api-proxy-sidecar.md, and authentication-architecture.md all confirm the sidecar is always enabled — --enable-api-proxy is a deprecated no-op and --no-enable-api-proxy is rejected at runtime (src/cli-options.ts). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit ec76bf3 |
Collaborator
|
@copilot rebase main and resolve conflicts |
…proxy-always-enabled-02350-a17ccbb2c6686112 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
Merged |
lpcox
deleted the
docs/auth-readme-api-proxy-always-enabled-02350-a17ccbb2c6686112
branch
September 19, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Protected files were modified in this change.
This pull request is in
request-reviewmode and requires explicit human scrutiny before merge.Protected files:
README.mdSummary
src/cli-options.ts,src/services/agent-environment/excluded-vars.ts,containers/api-proxy/management.js,containers/api-proxy/startup.js,containers/agent/api-proxy-health-check.sh,src/constants/placeholders.ts).src/cli-options.tsshows--enable-api-proxyis a deprecated no-op and--no-enable-api-proxyis rejected at runtime — the sidecar cannot be disabled. This matches the already-correct wording indocs/api-proxy-sidecar.md("The API proxy sidecar is always enabled") anddocs/awf-config-spec.md("The API proxy sidecar is always started; there is no disabled mode.").Documentation Changes
README.md: Changed the API proxy sidecar bullet in "How it works" from*(optional)*to*(always enabled)*, aligning it withdocs/api-proxy-sidecar.md,docs/awf-config-spec.md, and the current CLI implementation.Validation
src/cli-options.ts(--enable-api-proxydeprecated/no-op,--no-enable-api-proxyrejected at runtime),src/services/agent-environment/excluded-vars.ts,containers/api-proxy/management.js,containers/api-proxy/startup.js,containers/agent/api-proxy-health-check.sh,src/constants/placeholders.ts,containers/api-proxy/copilot-auth.test.js,containers/api-proxy/copilot-adapter-enterprise.test.js,containers/api-proxy/copilot-byok.test.js.[docs] auth:PRs exist to deduplicate against, and re-verified fix: isolate Actions OIDC from agent container #6894 and Ensure HTTP MCP GitHub OIDC bypasses the AWF agent credential boundary gh-aw#50053 status directly via the GitHub API.git diffscanned for token/key/JWT patterns and credential-bearing URLs — none found; the only change is the word "optional" → "always enabled".Sources