Add optional Windows ROCm backend for DiffusionGemma - #1
Open
Yasei-no-otoko wants to merge 1 commit into
Open
Yasei-no-otoko wants to merge 1 commit into
Yasei-no-otoko wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Four moderate issues remain in model loading, rejected-request handling, numeric validation, and request-wide timeout enforcement.
Review effort: Lite
Findings: None
What changed in this PR
Adds an optional Windows ROCm/PyTorch backend for DiffusionGemma, with launch tooling, smoke tests, and documentation.
Changes:
- Adds ROCm server, optional dependencies, and PowerShell lifecycle management.
- Adds HTTP smoke tooling and backend tests.
- Adjusts request timeout handling for long inference.
| File | Description |
|---|---|
test/test_rocm_server.py |
Backend validation tests |
test/index.test.ts |
Timeout regression tests |
test/http-smoke.test.ts |
HTTP smoke tests |
src/index.ts |
Inference timeout handling |
scripts/start-rocm.ps1 |
Windows launcher and cleanup |
scripts/rocm_server.py |
ROCm-compatible inference backend |
scripts/http-smoke.ts |
End-to-end smoke command |
requirements-rocm.txt |
Optional Python dependencies |
README.md |
ROCm overview and commands |
package.json |
Bun configuration and scripts |
docs/gfx1151.md |
Windows ROCm setup guide |
.gitignore |
ROCm runtime exclusions |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional Windows ROCm backend for the original DiffusionGemma checkpoint, validated on Radeon 8060S (
gfx1151). LocalJev continues to use its OpenAI-compatible upstream interface: users can connect an existing ROCm server through the normal environment variables, or choose the bundled PyTorch/Transformers adapter. The oMLX defaults and decision/evaluation logic stay unchanged.The implementation includes:
ROCmFPX is not a dependency. It was used only as an external runner for supplementary Q8 validation. This PR includes no ROCmFPX patches, build scripts, models or evaluation dumps. The guide links that historical result separately and does not present its 240/240 coverage as an FP16-adapter result. Python dependencies are optional and deliberately do not install/replace the user's HIP PyTorch wheel.
Validation for this PR:
start-rocm.ps1 -CheckOnlypassed with Windows PowerShell 5.1 and PowerShell 7 on the gfx1151 host, without loading model weights./ready→/v1/systemonesmoke requests on September 20; both validated choice, score and noul outputs.OpenAI Codex assisted with the implementation, validation and PR preparation at the contributor's request.