user: fail closed if supplementary groups survive a denied setgroups - #320
Open
andreeapid wants to merge 1 commit into
Open
andreeapid wants to merge 1 commit into
andreeapid wants to merge 1 commit into
Conversation
After the parent writes "deny" to /proc/pid/setgroups, setgroups(2) fails with EPERM and this is treated as expected. That is only safe if no supplementary groups are left, and entering a user namespace does not drop them. Check with getgroups(2) and fail if any group remains.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make teststarts a jail from a process that carries an inheritedsupplementary group and expects nsjail to refuse:
On Ubuntu 26.04 (kernel 7.0.0-15-generic) master returns 0 instead of the
expected 255. After the parent writes
denyto/proc/pid/setgroups,setgroups(2)fails withEPERMand that is treated as expected, but enteringa user namespace does not drop supplementary groups, so the jailed process
keeps the ones it inherited.
Check with
getgroups(2)and fail if any group remains.With the patch the test above returns 255 and logs
setgroups(0, []) failed and 1 supplementary group(s) remain. The--clear-groupsvariant still returns 0,and an ordinary jail still starts.