Consolidate tabs - #8511
Open
jonathanawesome wants to merge 23 commits into
Open
Consolidate tabs#8511jonathanawesome wants to merge 23 commits into
jonathanawesome wants to merge 23 commits into
Conversation
jonathanawesome
added this pull request to stack #8508
September 18, 2026 00:59
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
jonathanawesome
force-pushed
the
consolidate-tabs
branch
from
September 20, 2026 22:43
1aaf989 to
7321c03
Compare
Collaborator
jonathanawesome
force-pushed
the
consolidate-tabs
branch
from
September 21, 2026 00:01
7321c03 to
c21daa3
Compare
…views against ui/tabs, and the tabs inventory
…he contract picker as a base Select
…to base SecondaryNavigation and drop the tabs-based nav link
…or and new proposal page onto base Tabs, and scope the Monaco presentation reset so the tab indicator paints
…proposal editor service tabs onto base Tabs, with service renaming in the settings panel
…ry with call-site previews for Tabs, TabbedView, SecondaryNavigation and the laboratory ToggleGroup
…ith call-site previews, move TabbedView's picker out of the tablist, and fix the header tab sizes, exact link matching and the checks and history state resets
…e gear button, and let the vertical Tabs panel scroll inside a page that fixes its height
…tus icons out of the leading slot, clear of the selection check
…ith a button to scope to it, and base Legend, a key to icons shown without their text, and move TabbedView under Components in foundry
…eta cards on DescriptionList
…name from its text
…s a visible focus ring
…e FailureCard and the trigger glyph
…e can be removed from the keyboard
…d navigation links share a quiet dotted one, and the legacy ring token follows the accent
jonathanawesome
force-pushed
the
consolidate-tabs
branch
from
September 21, 2026 15:50
c21daa3 to
a824a24
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
ui/tabsonto three base components on Base UI.Valid uses of
tabswere migrated 1:1 with only slight visual changes (ie animated active indicator).TabbedViewis a new wrapper component for the previously-nested tab views on checks and history.SecondaryNavigationis a<nav>of router links replacing the old bits, which were navigation styled as tabs.ui/tabs.tsx,navigation/secondary-nav-link.tsxand@radix-ui/react-tabsare deleted.Found along the way
[role='presentation'] { background: transparent !important }, cleared the background of every presentation-role element on the page.aria-labelwhere none does. The trigger is a combobox, which takes no name from its text.--ringtoken follows the accent so the old button matches until it goes.Checks & History updates
DescriptionListnow, which gained atitleterm style (12px medium terms over 13px values) and auto-fit columns.FailureCard.Legendexplains the status iconscriticalcolor token instead of raw red shades.TARGET=<target id> pnpm seed:historyreplays a schema history against any target: versions and checks over six weeks, and on a federation project four contracts with a failed contract version and checks that fail only on a contract.