Consolidate accordion - #8521
Open
jonathanawesome wants to merge 9 commits into
Open
jonathanawesome wants to merge 9 commits into
jonathanawesome wants to merge 9 commits into
Conversation
jonathanawesome
added this pull request to stack #8508
September 19, 2026 22:25
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
jonathanawesome
force-pushed
the
consolidate-accordion
branch
from
September 20, 2026 22:44
99ed361 to
35c0ca1
Compare
Collaborator
jonathanawesome
force-pushed
the
consolidate-accordion
branch
from
September 21, 2026 00:01
35c0ca1 to
ead939e
Compare
…ermission detail view onto base Accordion
…ion, keep the hairline under every list item, and add a plain variant for the alert form's lone disclosure
…ordion, and give a lone service a Card instead of an accordion locked open
…side the trigger and the e2e hooks on the item and its trigger
…render the accordion call-site preview on base Accordion
jonathanawesome
force-pushed
the
consolidate-accordion
branch
from
September 21, 2026 15:50
ead939e to
23ef888
Compare
jdolle
approved these changes
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves every accordion in the app onto one base
Accordion, on Base UI, and deletesui/accordion,v2/accordionand@radix-ui/react-accordion.Found along the way
keepMountedkeeps that working, with a comment saying why.