Consolidate button - #8524
Open
jonathanawesome wants to merge 83 commits into
Open
Consolidate button#8524jonathanawesome wants to merge 83 commits into
jonathanawesome wants to merge 83 commits into
Conversation
jonathanawesome
added this pull request to stack #8508
September 20, 2026 22:12
jonathanawesome
force-pushed
the
consolidate-button
branch
from
September 20, 2026 23:06
3ab3d4c to
f126471
Compare
Collaborator
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
jonathanawesome
force-pushed
the
consolidate-button
branch
from
September 21, 2026 00:01
5f7f7c4 to
83da338
Compare
…views against ui/tabs, and the tabs inventory
…he contract picker as a base Select
…to base SecondaryNavigation and drop the tabs-based nav link
…or and new proposal page onto base Tabs, and scope the Monaco presentation reset so the tab indicator paints
…proposal editor service tabs onto base Tabs, with service renaming in the settings panel
…ry with call-site previews for Tabs, TabbedView, SecondaryNavigation and the laboratory ToggleGroup
…ith call-site previews, move TabbedView's picker out of the tablist, and fix the header tab sizes, exact link matching and the checks and history state resets
…e gear button, and let the vertical Tabs panel scroll inside a page that fixes its height
…tus icons out of the leading slot, clear of the selection check
…ith a button to scope to it, and base Legend, a key to icons shown without their text, and move TabbedView under Components in foundry
…eta cards on DescriptionList
…name from its text
…s a visible focus ring
…e FailureCard and the trigger glyph
…e can be removed from the keyboard
…d navigation links share a quiet dotted one, and the legacy ring token follows the accent
…ook-form, with a page spec written against the Formik version first
…eact-hook-form, with page spec tests written against the Formik version first
…d react-hook-form, with page spec tests written against the Formik version first
… and react-hook-form, with page spec tests written against the Formik version first
…-form, with a spec written against the Formik version first
…ea specs onto base Form, mount the real ticket and operation forms in the overlay previews, and drop formik, yup and the yup transformer
…ture, and delete ui/form, ui/label and @radix-ui/react-label
…the brand marks in ui/brand-icon, and drop both icon packages
…vigate, and show every old button shape beside its base rendering in the inventory
…s onto base Button
…utton, and take the sub-page nav and the explorer letter strips off Button onto their own classes
… pages onto base Button, and take the stepper circles and calendar cells onto their own classes
… the base call-sites fixture, and delete ui/button and @radix-ui/react-slot
…>} at the call sites
jonathanawesome
force-pushed
the
consolidate-button
branch
from
September 21, 2026 15:50
83da338 to
a80cf96
Compare
Co-authored-by: Jonathan Brennan <jonathanawesome@users.noreply.github.com>
n1ru4l
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves every button in the app onto base
Button, on Base UI's render hook, and deletesui/button,@radix-ui/react-slot,@radix-ui/react-iconsandreact-icons.Every Radix and react-icons icon is on lucide. The brand marks lucide does not carry, or has deprecated, live in
ui/brand-icon.tsx: GraphQL, Hive, GitHub, Google, Okta, OpenID and Slack. The twenty hand-rolled icons in the oldui/icon.tsxthat duplicated lucide glyphs are gone with it.Four things rendered the old Button with most of its defaults undone and are plain elements with their own classes now: the vertical sub-page nav item (also used by the target alerts page), the stepper's step circles, the calendar's nav arrows and day cells, and the explorer's A–Z letter strips.
Found along the way
CopyTexthover button both relied on classes the base Button does not accept; both sit on wrappers now.asChildslots had no caller and are gone.Design changes to review