Make the physical layer initialization stage depend on single mobility - #1222
Merged
levy merged 1 commit intoSep 25, 2026
Merged
Conversation
PHYSICAL_LAYER depended on GROUP_MOBILITY but not on SINGLE_MOBILITY, although radios and physical layers query the node position during initialization. The stages are numbered in the right order only because SINGLE_MOBILITY happens to be registered before PHYSICAL_LAYER; nothing in the dependency graph guarantees it. Simu5G declares this dependency itself to be safe. The stage numbering does not change.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INITSTAGE_PHYSICAL_LAYERdepended onGROUP_MOBILITYbut not onSINGLE_MOBILITY, although radios and physical layers read the node position while they initialize. Today the order comes out right only becauseSINGLE_MOBILITYis registered beforePHYSICAL_LAYERinInitStages.cc. Nothing in the dependency graph requires it.Simu5G has carried
Define_InitStage_Dependency(PHYSICAL_LAYER, SINGLE_MOBILITY)in its own code to be safe.This PR adds the dependency to INET.
The stage numbering doesn't change:
SINGLE_MOBILITYstays 6 andPHYSICAL_LAYERstays 8.