Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Improves inspect-view readability by sorting multi-valued attributes deterministically.
Changes:
- Adds a
sort_valuestemplate filter with mixed-type fallback handling. - Applies sorting to multi-attribute values in the inspect template.
File summaries
| File | Description |
|---|---|
packages/serveradmin/serveradmin/servershell/templatetags/servershell.py |
Adds multi-value sorting logic. |
packages/serveradmin/serveradmin/servershell/templates/servershell/inspect.html |
Sorts values before displaying them. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
brainexe
force-pushed
the
md_inspect_sort
branch
from
September 18, 2026 06:00
8f66330 to
99dab48
Compare
brainexe
force-pushed
the
md_inspect_sort
branch
from
September 18, 2026 07:05
99dab48 to
d44becb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
having views with many unsorted multi-attributes are a bit hard to search
bad example: