Day 102: Standalone Templates page - #2
Merged
Merged
Conversation
Adds a /templates route with full list/create/edit/delete, independent
of the Compose page's compact picker widget. Extracted the
{{variable}}-detection regex (previously only defined inline in
TemplatePicker) into dashboard/src/lib/templateVariables.ts, shared by
both the picker and the new page, so the "no duplication of logic"
requirement covers more than just the REST calls.
Also commits the implementation-tracker.md infra (CLAUDE.md rule +
the tracker file itself) that was drafted but never committed after
Day 101, updates it for Days 101-102, corrects its stale "no Docker
available" note now that Docker is installed, and records the
identity/auth security gaps found during the Day 101 follow-up
investigation as a tracked but unassigned known follow-up.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/templatesroute with full list/create/edit/delete, independent of the Compose page's compact picker widget.{{variable}}-detection regex (previously inline-only inTemplatePicker) intodashboard/src/lib/templateVariables.ts, shared by both the picker and the new page — went beyond the checklist's "no duplication of logic" API-layer requirement to also cover this.implementation-tracker.mdinfra (drafted in an earlier session but never committed after Day 101), updates it for Days 101–102, corrects a stale "no Docker available" note now that Docker is installed on this host, and records the identity/auth security gaps found during a Day 101 follow-up investigation as a tracked-but-unassigned known follow-up (not silently dropped, not yet actioned).Test plan
tsc -b,oxlint,vite buildall cleandashboard/e2e/templates.spec.ts— create/edit/delete, plus a cross-page check that a template created on/templatesis immediately usable from Compose's picker