Due to the way the Crontrol "Pauser" works by injecting just another regular action with a priority of -9999 all executions in ActionScheduler are logged as "Completed".
This is kind of misleading as the actual, expected action is not executed at all. Only the runtime of 0s might indicate something.
I am not quite sure if this should be handled here or in AS and would like to open it up for discussion.
As AS supports proper Exceptions, simply throwing an Exception with a Message "Paused by WP-Crontrol" in the Crontrol Pauser would do the trick. This would result in marking the execution in AS as "failed" with the Message of the Exception in the AS logs.
The other solution in AS would actually require checking for the registered Actions to see if the first one is the Pauser. So I believe the better way would be to to handle it within the Crontrol Pauser explicitly.
What do you think?
Due to the way the Crontrol "Pauser" works by injecting just another regular action with a priority of -9999 all executions in ActionScheduler are logged as "Completed".
This is kind of misleading as the actual, expected action is not executed at all. Only the runtime of 0s might indicate something.
I am not quite sure if this should be handled here or in AS and would like to open it up for discussion.
As AS supports proper Exceptions, simply throwing an Exception with a Message "Paused by WP-Crontrol" in the Crontrol Pauser would do the trick. This would result in marking the execution in AS as "failed" with the Message of the Exception in the AS logs.
The other solution in AS would actually require checking for the registered Actions to see if the first one is the Pauser. So I believe the better way would be to to handle it within the Crontrol Pauser explicitly.
What do you think?