Skip to content

chore: update gradle - #26

Draft
ccrowell-kr wants to merge 1 commit into
mainfrom
updates
Draft

ccrowell-kr wants to merge 1 commit into
mainfrom
updates

Conversation

@ccrowell-kr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 26, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Gradle Wrapper configuration/scripts as part of a Gradle version bump.

Changes:

  • Bump Gradle Wrapper distribution from 8.7 to 8.14.5 in gradle-wrapper.properties.
  • Update wrapper launch scripts (gradlew, gradlew.bat) including SPDX header additions.
  • Change wrapper startup invocation to use java -jar ...gradle-wrapper.jar (instead of org.gradle.wrapper.GradleWrapperMain via -classpath).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
gradlew.bat Adds SPDX header and changes wrapper invocation to java -jar.
gradlew Adds SPDX header, updates generated-script reference URL, and changes wrapper invocation to java -jar.
gradle/wrapper/gradle-wrapper.properties Updates Gradle distribution URL to 8.14.5.
Suppressed comments (1)

gradlew:217

  • The script now launches the wrapper with java -jar ...gradle-wrapper.jar, but still adds -classpath "$CLASSPATH". With -jar, the classpath argument is ignored, and keeping it makes the startup arguments harder to reason about (especially since CLASSPATH is no longer a real path). Consider removing the -classpath argument from the constructed java command.
set -- \
        "-Dorg.gradle.appname=$APP_BASE_NAME" \
        -classpath "$CLASSPATH" \
        -jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \
        "$@"

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread gradlew
Comment thread gradle/wrapper/gradle-wrapper.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants