Add Seal/Sign Support for NTLM - #192
Open
JoeyShapiro wants to merge 4 commits into
Open
JoeyShapiro wants to merge 4 commits into
JoeyShapiro wants to merge 4 commits into
Conversation
Owner
|
Hi! Thanks for your contributions. Unfortunately, it removes encryption.go on which #188 and #191 are based. I think there may be a path for having all three, but I need a few confirmation before:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added encryption support for NTLM so requests can be made to servers with sign/seal enabled.
I made the changes required to Azure/go-ntlmssp and am now putting them here.
This works on a windows 2016 vm with the default
quick config, which requires encryption.I removed encryption.go and the bodgit/ntlmssp library, as they seem unused and never wired up. Let me know if you need me to add them back for backwards compatibility. But I figured it made more sense to use the one from Azure that is already in and used in other places.
I really want this change so I can use this library to interact with all kinds of winrm servers. So let me know if there are any changes that need to be made for a merge. I am more than happy to make changes.