Skip to content

fix(app/backend): external file renames break mp updates - #7618

Merged
mergify[bot] merged 2 commits into
mainfrom
cal/fix-renaming-external-files-breaks-modpack-vers-switching
Sep 21, 2026
Merged

mergify[bot] merged 2 commits into
mainfrom
cal/fix-renaming-external-files-breaks-modpack-vers-switching

Conversation

@IMB11

@IMB11 IMB11 commented Sep 18, 2026

Copy link
Copy Markdown
Member

Renaming external files will break the "Switch version" flow for linked modpacks + give incorrect error reason

@IMB11
IMB11 requested a review from a team September 18, 2026 14:58
@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@IMB11

IMB11 commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

rebase

✅ Branch has been successfully rebased

@IMB11
IMB11 force-pushed the cal/fix-renaming-external-files-breaks-modpack-vers-switching branch from d2e2c72 to 7a9c3bd Compare September 21, 2026 10:19
@IMB11

IMB11 commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio rebase

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

rebase

✅ Branch has been successfully rebased

@IMB11
IMB11 force-pushed the cal/fix-renaming-external-files-breaks-modpack-vers-switching branch from 7a9c3bd to 3c8be77 Compare September 21, 2026 13:22
@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Queued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merge Queue Status

  • Entered queue2026-09-21 14:07 UTC · Rule: default · triggered by @IMB11 with the merge queue checkbox
  • 🚫 Left the queue2026-09-21 14:07 UTC · at 3c8be776cac63e020985502b2e6cd671f6d60d25

This pull request spent 11 seconds in the queue, with no time running CI.

Reason

The pull request conflicts with the base branch

Hint

You should update or rebase your pull request.

If you want to requeue this pull request, you can post a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

…rnal-files-breaks-modpack-vers-switching

# Conflicts:
#	packages/app-lib/src/state/instances/commands/sync_content_files.rs
@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merge Queue Status

This pull request spent 17 minutes 50 seconds in the queue, including 17 minutes 26 seconds running CI.

Required conditions to merge

@mergify mergify Bot added queued and removed dequeued labels Sep 21, 2026
@mergify
mergify Bot merged commit 532c1aa into main Sep 21, 2026
7 checks passed
@mergify
mergify Bot deleted the cal/fix-renaming-external-files-breaks-modpack-vers-switching branch September 21, 2026 14:56
@mergify mergify Bot removed the queued label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants