pbr-1.2.3: bump PKG_RELEASE from 95 to 97 - #178
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed since 1.2.3-r95.
Three faults, all of which stopped the service from starting.
pbrvalidates its wholenftfile in one pass, so any one of them meantFAILED TO STARTand no policy routing at all — not just the policy at fault.Setting Default ICMP Interface broke the service when IPv6 is enabled. The IPv6 rule was written as
ip6 protocol icmp, whichnftrefuses: IPv6 headers have noprotocolfield, and the IPv6 ICMP protocol isicmpv6. Anyone who set that option and had IPv6 on lost all policy routing. It is now emitted correctly.A policy's
Protocolsetting is reported when it cannot do what it looks like it does.protoqualifies a port match rather than matching on its own, so setting it without a port silently dropped it and the policy routed every protocol instead of the one you chose. Setting it to a protocol that has no ports —icmpand most of the list — with a port produced a rulenftrefuses. The first is now a warning naming the policy; the second rejects just that policy, so the rest of the ruleset survives.The
Protocoldropdown now offers only protocols that can work —tcp,udp,sctp,dccp,udplite. The list was previously built from every line of/etc/protocols, and 41 of the 46 entries it offered could not work. A value an existing policy already holds is still shown, marked(unsupported), so opening the page does not silently change your configuration.To route ICMP, use Default ICMP Interface on the Advanced tab rather than a policy — a policy cannot express it. If you want "all traffic of one protocol", set the protocol and give it the port range
0-65535.Documentation for all of this is in the 1.2.3 README, which also corrects the
chainoption:inputandpostroutingwere listed for years and have never worked — the valid values areprerouting,forwardandoutput.The compatibility number moves to 37, so
pbrandluci-app-pbrmust be updated together.PKG_RELEASEon the1.2.3branch moves in steps of two and stays odd — …91, 93, 95, 97. r96 is not a skipped release; there is no even number in this series.Paired with mossdef-org/luci-app-pbr#49