fix(release): mark suffixed tags as prereleases on GitHub - #76
Merged
Merged
Conversation
Release candidates were published as regular releases, so GitHub promoted them to "Latest". install.sh and the README download links resolve through releases/latest, which meant an rc tag would be served to every installer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Create GitHub Releasestep never setprerelease, so tags such asv2.0.0-rc.2were published as regular releases and promoted to "Latest".install.shand the READMEreleases/latest/download/...links both resolve through the latest release, so an rc tag would be served to every installer using those paths.This sets
prereleasewhenever the tag contains a-, matching the condition the Homebrew job already uses to skip prerelease tags. npm publishing is unaffected;scripts/publish.shalready derives the dist-tag from the version suffix.Why now
Needs to be on
mainbefore taggingv3.0.0-rc.1for #74, since the release workflow runs from the tagged commit.Test plan
releases/lateststill resolves tov2.1.0🤖 Generated with Claude Code
Note
Low Risk
CI-only change to GitHub release metadata; no runtime or npm publish behavior changes.
Overview
Sets the GitHub Release Create Release step to mark releases as pre-releases when the tag name contains a
-(e.g.v3.0.0-rc.1), viaprerelease: ${{ contains(github.ref_name, '-') }}.That keeps suffixed tags from becoming GitHub’s Latest release, so
install.shand READMEreleases/latest/download/...links keep pointing at stable builds instead of RCs. The condition matches the existing Homebrew job guard that skips hyphenated tags.Reviewed by Cursor Bugbot for commit 8d950fe. Bugbot is set up for automated code reviews on this repo. Configure here.